Skip to content

[MCH] [MRRTF-107] Move Digit class from MCHBase to DataFormatsMCH#5764

Merged
davidrohr merged 1 commit into
AliceO2Group:devfrom
aphecetche:mch-digit-move-to-dataformats
Mar 24, 2021
Merged

[MCH] [MRRTF-107] Move Digit class from MCHBase to DataFormatsMCH#5764
davidrohr merged 1 commit into
AliceO2Group:devfrom
aphecetche:mch-digit-move-to-dataformats

Conversation

@aphecetche
Copy link
Copy Markdown
Collaborator

The only changes in this PR are related to the move of the MCH Digit class from MCHBase library to DataFormatsMCH library (or to the replacement of FairMQLogger by Framework/Logger to simplify MCHBase lib dependencies declaration @pillot)

@aphecetche
Copy link
Copy Markdown
Collaborator Author

@Barthelemy I naively believed that with my prep work AliceO2Group/QualityControl#647 this PR would be green at first try ... I was wrong ;-)
I wrongly assumed the CI would pick the latest and greatest QC, but apparently it's using a tagged version... So I guess I'll have to wait for a QC tag for this one to pass, is that correct ?

@davidrohr
Copy link
Copy Markdown
Collaborator

@aphecetche : yes, QC tests v.s. O2/dev, but O2 tests agains QC/tagged (since the latter is what is installed by default with aliBuild)

@Barthelemy
Copy link
Copy Markdown
Collaborator

I plan on releasing QC today or tomorrow.

@Barthelemy
Copy link
Copy Markdown
Collaborator

alisw/alidist#2922

@Barthelemy
Copy link
Copy Markdown
Collaborator

v1.14 is out

@aphecetche aphecetche force-pushed the mch-digit-move-to-dataformats branch from afb5f5f to dd116f8 Compare March 24, 2021 08:38
@aphecetche
Copy link
Copy Markdown
Collaborator Author

@shahor02 this one is ready to be merged (I don't mention the review part as it's basically just moving things around, but of course feel free to actually review if you want to ;-) )

(note that once moved the digit class will undergo some changes following discussions on the CTF we had with you and that we are having with Andrea & Philippe, e.g. time will probably disappear altogether, and ADC will be shortened to 32 bits)

@davidrohr davidrohr merged commit 884e62b into AliceO2Group:dev Mar 24, 2021
@aphecetche aphecetche deleted the mch-digit-move-to-dataformats branch March 24, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants